umpf: answer interactive prompts with default when --default set #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think a |
|
Ok, but doesn't it make sense to have piping yes behave as expected as well? |
|
Fair point. I would rename the option then though. How about |
|
Sounds good. |
a3f
changed the title
michaelolbrich
requested changes
Jan 31, 2025
When building or tagging an umpf, umpf can ask which branch to use when multiple are available. Piping yes(1) into umpf in this case doesn't work, because the variable populated by read in that case is left empty. Provide for this use case, a --default option that will take a default if one is known. Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
michaelolbrich
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building or tagging an umpf, umpf can ask which branch to use when multiple are available. Piping
yes(1)into umpf in this case doesn't work, because the variable populated by read in that case is left empty.Handle this case to reduce user confusion.